Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tldraw): disable selecting shapes on certain cases #15637

Merged

Conversation

germanocaumo
Copy link
Collaborator

What does this PR do?

  • For presenter/multiuser Don't allow selecting the background shape (could be done with right click on empty area)
  • For viewers: don't allow selecting anything (also hides the selection brush)

before:
select_before
after:
select_after

Closes Issue(s)

Closes #15378

- For presenter/multiuser Don't allow selecting the background shape (could be done with right click on empty area)
- For viewers: don't allow selecting anything (also hides the selection brush)
@antobinary antobinary added this to the Release 2.6 milestone Sep 6, 2022
@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug D 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
18.2% 18.2% Duplication

@ramonlsouza ramonlsouza merged commit e413499 into bigbluebutton:v2.6.x-release Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants