refactor (bbb-soffice): Switch parent image to amazoncorretto:17-alpine #15743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavotrott
changed the title
|
SonarCloud Quality Gate failed.
|
TiagoJacobs
reviewed
Sep 29, 2022
| RUN apt update && apt -y install locales-all fontconfig libxt6 libxrender1 | ||
| RUN apt update && apt -y install libreoffice \ | ||
| && rm -f \ | ||
| /usr/share/java/ant-apache-log4j-1.10.9.jar \ |
There was a problem hiding this comment.
Hello @gustavotrott - please check what is the version of log4j that's installed in this new implementation
I believe these removals was to ensure the vulnerable version would not be there.
There was a problem hiding this comment.
from within the docker, run:
find / 2>&1 | grep log4jThere was a problem hiding this comment.
The log4j files is no longer present in this image!
TiagoJacobs
approved these changes
Sep 29, 2022
| RUN apt update && apt -y install locales-all fontconfig libxt6 libxrender1 | ||
| RUN apt update && apt -y install libreoffice \ | ||
| && rm -f \ | ||
| /usr/share/java/ant-apache-log4j-1.10.9.jar \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in https://hub.docker.com/_/openjdk, the current parent image
openjdkis deprecated!This PR will switch the parent docker image to
amazoncorretto.It will bring some pros: