fix (bbb-web): improvements on presentations upload #15990
Conversation
| } | ||
| } | ||
|
|
||
| def detectMimeType(File pres) { |
There was a problem hiding this comment.
Avoid placing this kind of function in the Controller... I think it fits better in the class SupportedFileTypes in bbb-common-web.
There was a problem hiding this comment.
Also try to use the Java methods to get the mime type.
|
|
||
| public final class Util { | ||
|
|
||
| private static Logger log = LoggerFactory.getLogger(DocumentConversionServiceImp.class); |
There was a problem hiding this comment.
| private static Logger log = LoggerFactory.getLogger(DocumentConversionServiceImp.class); | |
| private static Logger log = LoggerFactory.getLogger(Util.class); |
gustavotrott
changed the title
Code improvements using best practices
…-mime-insert-document
|
I'm not able to send
The mime identified for the file is |
|
When I receive an error I can't send new files! cant-upload-pres-after-error.mp4 |
Add exception to accept ppt with pptx mime
|
Kudos, SonarCloud Quality Gate passed!
|
gustavotrott
changed the title
What does this PR do?
It fixes 3 things in total:
insertDocumentwith presentation-uploader toast notification;insertDocumentendpoint and deletion of mistaken files.