Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Short cut) Zoom to Fit -> Reset Zoom #16278

Merged
merged 1 commit into from Dec 29, 2022

Conversation

hiroshisuga
Copy link
Contributor

What does this PR do?

Change the shortcut name "Zoom to Fit" to "Reset Zoom"

Closes Issue(s)

Closes #

Motivation

In my personal opinion, "reset zoom" is easier to understand.

More

  • Added/updated documentation

@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.4% 2.4% Duplication

@antobinary antobinary added this to the Release 2.7 milestone Dec 29, 2022
@antobinary antobinary merged commit 9158256 into bigbluebutton:develop Dec 29, 2022
@antobinary
Copy link
Member

Thank you @hiroshisuga ! Thanks @KDSBrowne for reviewing!

@hiroshisuga
Copy link
Contributor Author

hiroshisuga commented Jan 13, 2023

@antobinary , @KDSBrowne , I am not sure if "zoom to fit" means "reset zoom" per se.
I realised that "zoom to fit" could mean "zoom as much as possible, as long as all the drawings are shown". At least in the tldraw website, the app behaves like that. I could not confirm it in demo.bigbluebutton.org server because the shortcuts are not working currently..

Update: on the current test26 server (beta6) the shortcut behaves like "reset zoom".

@hiroshisuga hiroshisuga deleted the patch-55 branch June 26, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants