Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove user #16465

Merged
merged 5 commits into from Jan 23, 2023
Merged

test: Remove user #16465

merged 5 commits into from Jan 23, 2023

Conversation

gabriellpr
Copy link
Collaborator

What does this PR do?

Implements two tests, the simple remove user test and the remove user and prevent rejoining test.

Both tests have an implementation to accept the two screens shown below when the user is removed.

The test will be modified when issue #16463 is resolved.

test-failed-2

test-finished-2

@antobinary antobinary added this to the Release 2.6 milestone Jan 13, 2023
@antonbsa antonbsa self-requested a review January 13, 2023 15:12
@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Member

@antonbsa antonbsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks pretty good! I just left a few comments below, most related to indentation

bigbluebutton-tests/playwright/core/page.js Outdated Show resolved Hide resolved
bigbluebutton-tests/playwright/user/multiusers.js Outdated Show resolved Hide resolved
bigbluebutton-tests/playwright/user/multiusers.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
1.9% 1.9% Duplication

@antobinary antobinary merged commit 58187c6 into bigbluebutton:v2.6.x-release Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants