Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sticky notes are giant on portrait view slides #16721

Merged

Conversation

ramonlsouza
Copy link
Member

What does this PR do?

Force slide scaling to a fixed size, fixing annotation size issues.

before

Screencast.from.2023-02-14.13-35-35.webm

after

Screencast.from.2023-02-14.13-34-06.webm

Closes Issue(s)

Closes #16145

@ramonlsouza ramonlsouza added this to the Release 2.6 milestone Feb 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@KDSBrowne KDSBrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the large annotations on smaller slides. They all scale appropriately in both landscape and portrait docs for the presenter and viewers.

Changes will need to be made to the recordings for the annotation positions. Currently they appear in the wrong location depending on the size of the slide.

@antobinary
Copy link
Member

@KDSBrowne could you please open an issue for the recording work -- looks like you have some ?screenshots of how it should be vs how it is now

Copy link
Contributor

@kepstin kepstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; the fix is straightforwards and general, and it should be easy to adapt the bbb-presentation-video tool to match this scaling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants