New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/feature (bbb-web): Add new join param errorRedirectUrl
and fix to respect redirect
#17202
fix/feature (bbb-web): Add new join param errorRedirectUrl
and fix to respect redirect
#17202
Conversation
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
re-tagging for 2.7 |
errorRedirectUrl
and fix to respect redirect
Looks like this new param And add the Docs for this new param in API section, please! |
bigbluebutton-web/grails-app/controllers/org/bigbluebutton/web/controllers/ApiController.groovy
Outdated
Show resolved
Hide resolved
bigbluebutton-web/grails-app/controllers/org/bigbluebutton/web/controllers/ApiController.groovy
Outdated
Show resolved
Hide resolved
This pull request has conflicts ☹ |
I think the option And as we can see in the print it also override the default |
cfcdb94
to
657d608
Compare
Kudos, SonarCloud Quality Gate passed! |
hey @paultrudel , the code is alright! are you going to update the Docs in this PR? or in a subsequent? |
I am going to open another PR to update the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
b5440c0
into
bigbluebutton:v2.7.x-release
What does this PR do?
The
join
API did not respect theredirect
parameter and would continue to redirect users on errors even ifredirect
was set to false. Also added support for a new parameter onjoin
API calls calledredirectUrl
that allows a user to either provide a custom URL to redirect users to, or it can be set tologout
to redirect the user to the meeting's logout URL.Closes Issue(s)
Closes #11241
Closes #12824