Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/feature (bbb-web): Add new join param errorRedirectUrl and fix to respect redirect #17202

Conversation

paultrudel
Copy link
Collaborator

What does this PR do?

The join API did not respect the redirect parameter and would continue to redirect users on errors even if redirect was set to false. Also added support for a new parameter on join API calls called redirectUrl that allows a user to either provide a custom URL to redirect users to, or it can be set to logout to redirect the user to the meeting's logout URL.

Closes Issue(s)

Closes #11241
Closes #12824

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@antobinary antobinary modified the milestones: Release 2.6, Release 2.7 Mar 27, 2023
@antobinary
Copy link
Member

re-tagging for 2.7

@antobinary antobinary changed the base branch from v2.6.x-release to v2.7.x-release April 11, 2023 16:12
@gustavotrott gustavotrott changed the title Add new join param and respect redirect fix/feature (bbb-web): Add new join param errorRedirectUrl and fix to respect redirect Apr 13, 2023
@gustavotrott
Copy link
Collaborator

Looks like this new param redirectUrl will be used only when it return some error, right?
So I suggest to name this param errorRedirectUrl .

And add the Docs for this new param in API section, please!

@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@gustavotrott
Copy link
Collaborator

I think the option redirectUrl=logout is not necessary.
Because this is the default behavior already.

image

And as we can see in the print it also override the default defaultServerUrl when the /join has params.logoutURL. I suggest to remove the option redirectUrl=logout and keep the previous behavior that is already what we want.

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gustavotrott
Copy link
Collaborator

hey @paultrudel , the code is alright!

are you going to update the Docs in this PR? or in a subsequent?

@paultrudel
Copy link
Collaborator Author

hey @paultrudel , the code is alright!

are you going to update the Docs in this PR? or in a subsequent?

I am going to open another PR to update the docs.

Copy link
Collaborator

@gustavotrott gustavotrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antobinary antobinary merged commit b5440c0 into bigbluebutton:v2.7.x-release Apr 14, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants