fix(freeswitch): include signalwire PR 1914 as a patch #17523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some issues with the way FreeSWITCH changes candidate pairs based on connectivity checks. That generally manifests as: 1) an asymmetric start time between inbound and outbound audio (eg inbound audio takes 20 seconds to come in while outbound works right out of the bat 2) wrong pairs being picked initially and FS taking longer than ideal to find a new one 3) 1006s, 4) .... This backports signalwire PR 1914 in an attempt to mitigate the aforementioned issues. The PR description explains the rationale rather well and seems sound. I've tested this in demo servers with midly satisfying results, but still needs further testing.
prlanzarin
force-pushed
the
u27/fix/fs-1914
branch
from
6822ef8
to
a2503f4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
the rationale rather well and seems sound. I've tested this in demo servers with mildly
satisfying results, but still needs further testing.
Closes Issue(s)
n/æ
Motivation
There are some issues with the way FreeSWITCH changes candidate pairs
based on connectivity checks. That generally manifests as: 1) an asymmetric
start time between inbound and outbound audio (eg inbound audio takes 20
seconds to come in while outbound works right out of the bat
2) wrong pairs being picked initially and FS taking longer
than ideal to find a new one 3) 1006s, 4) ....