Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "Grid View" layout #17883

Merged
merged 6 commits into from May 18, 2023

Conversation

ramonlsouza
Copy link
Member

What does this PR do?

Implements a grid in the "Focus on video" layout with placeholders for the participants that did not share webcam

Screencast.from.2023-05-12.16-57-14.webm

Closes Issue(s)

Closes #13844

@ramonlsouza ramonlsouza added this to the Release 2.7 milestone May 12, 2023
@ramonlsouza ramonlsouza marked this pull request as ready for review May 12, 2023 20:01
@antobinary
Copy link
Member

Nice!!

@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@sonarcloud
Copy link

sonarcloud bot commented May 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@antobinary antobinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well locally. I have requested a couple of minor tweaks that can go into a new PR. The most noticeable one was a request for a border when we we a placeholder for the avatar (no webcam and no avatar image)

@antobinary antobinary changed the title Add "Grid View" layout feat: Add "Grid View" layout May 18, 2023
@antobinary antobinary merged commit 6e9eb02 into bigbluebutton:v2.7.x-release May 18, 2023
4 of 5 checks passed
@SamuelWei
Copy link
Contributor

I think it would be good, if you can switch between:

  • All webcams
  • All Webcams +all users with microphone only
  • Everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants