Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable self-view of webcam #17935

Merged
merged 4 commits into from May 17, 2023

Conversation

Scroody
Copy link
Collaborator

@Scroody Scroody commented May 16, 2023

What does this PR do?

This PR adds a feature that allows user to disable his on web cam, and in doing so, saving his own computer resources.

Closes Issue(s)

#16114

Example:

selcamfeat

@antobinary antobinary added this to the Release 2.7 milestone May 16, 2023
<Styled.Row>
<Styled.Col aria-hidden="true">
<Styled.FormElement>
{/* eslint-disable-next-line jsx-a11y/label-has-associated-control */}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to use eslint-disable only in exceptional circumstances.

@gustavotrott
Copy link
Collaborator

The name disableCam may lead to another interpretation.
I suggest to change the name of all variables related to this config to selfViewDisabled.

@gustavotrott gustavotrott changed the title New Feature: Self cam disabling feature: Disable self-view option May 17, 2023
@gustavotrott gustavotrott changed the title feature: Disable self-view option feat: Disable self-view option May 17, 2023
@antobinary antobinary changed the title feat: Disable self-view option feat: Disable self-view of webcam May 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ramonlsouza ramonlsouza merged commit c64cf5c into bigbluebutton:v2.7.x-release May 17, 2023
4 of 5 checks passed
@bersace
Copy link

bersace commented May 22, 2023

You're awesome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants