Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: connection status modal "adjusting your settings" button not working as expected #18024

Merged
merged 2 commits into from May 31, 2023
Merged

fix: connection status modal "adjusting your settings" button not working as expected #18024

merged 2 commits into from May 31, 2023

Conversation

ramonlsouza
Copy link
Member

What does this PR do?

  • fix "adjusting your settings" button appearing only when connection level is danger or critical
  • fix settings modal priority when inside connection status modal

@ramonlsouza ramonlsouza added this to the Release 2.7 milestone May 26, 2023
@ramonlsouza ramonlsouza requested a review from antonbsa May 26, 2023 18:34
antonbsa
antonbsa reviewed May 30, 2023
View reviewed changes
Copy link
Member

@antonbsa antonbsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fixed! I just saw the connection status button keeping focused and the tooltip displayed after exiting the settings

Peek.2023-05-30.11-24.mp4

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ramonlsouza ramonlsouza requested a review from antonbsa May 31, 2023 11:54
@antobinary antobinary merged commit 2a98312 into bigbluebutton:v2.7.x-release May 31, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonbsa antonbsa antonbsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ramonlsouza @antonbsa @antobinary