Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only record media while meeting is being actively recorded #18044

Merged

Conversation

prlanzarin
Copy link
Member

@prlanzarin prlanzarin commented May 30, 2023

What does this PR do?

  • feat: only record media while meeting is being actively recorded
    • Only record media (microphone, webcams and screens) while meeting is being actively recorded (ie an user has enabled recording in the conference). If the conference's recording is paused, media capture will stop as well (with appropriate recording events). This is the new default
    • This can be controlled via the recordFullDurationMedia bigbluebutton.properties setting/API create parameter - see More
  • build(bbb-webrtc-sfu): v2.9.13`

Closes Issue(s)

Partially #9202
The are still a bunch of other features that are recorded (eg chat, whiteboard, ...). This just tackles the real time media part.

More

A bigbluebutton.properties/API#create parameter called recordFullDurationMedia is added to control this behavior. The default is false (only capture while recording is active). Setting it to true enables the legacy behavior: always capture media if the meeting's recorded prop is true.

@antobinary antobinary added this to the Release 2.6 milestone May 31, 2023
Only record media (microphone, webcams and screens) while meeting is
being actively recorded (ie an user has enabled recording in the
conference). If the conference's recording is paused, media capture will
stop as well (with appropriate recording events).

A bigbluebutton.properties/API#create parameter called
`recordFullDurationMedia` is added to control this behavior. The default
is false (only capture while recording is active). Setting it to `true`
enables the current (legacy) behavior: always capture media if the
meeting's `recorded` prop is true.
@prlanzarin
Copy link
Member Author

Merging, ping/revert if anything major breaks.

@prlanzarin prlanzarin merged commit 0135813 into bigbluebutton:v2.6.x-release May 31, 2023
3 checks passed
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hiroshisuga
Copy link
Contributor

Would it be the option to set this in per-room basis?
In my personal opinion, (despite the privacy issue) it's a nice and unique feature of BBB that the admins can recover the recording even when they forgot to press the recording button (Zoom cannot do it). This feature has indeed saved my life for uncountable times.
Depending on teachers or classes, users may or may not want BBB to record everything in the server side. If the recordFullDurationMedia parameter can be set on each room, most of the demands will be fulfilled.

@prlanzarin
Copy link
Member Author

Would it be the option to set this in per-room basis?

@hiroshisuga Yes, this can be controlled server-wide and per-room. See:

A bigbluebutton.properties/API#create parameter called recordFullDurationMedia is added to control this behavior. The default is false (only capture while recording is active). Setting it to true enables the legacy behavior: always capture media if the meeting's recorded prop is true.

Setting recordFullDurationMedia=true in bigbluebutton.properties restores the old behavior server-wide. Using recordFullDurationMedia=true as an API create parameter, you can control this per-room.

@hiroshisuga
Copy link
Contributor

Fantastic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants