chore: Bump Etherpad to 1.9.1 #18276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A zero-width-space is used to work around an issue with Etherpad 1.9.1 where empty pads are not being created.
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Jul 10, 2023
This was referenced Jul 14, 2023
|
Please only merge this PR once mconf/ep_redis_publisher#7 has been merged. |
antobinary
merged commit 2d504a1
into
bigbluebutton:v2.6.x-release
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR upgrades
bbb-etherpadto use Etherpad 1.9.1.Motivation
The current release (1.8.17) is over a year old.
More
There's a known bug in Etherpad 1.9.1 that prevents empty pads from being created through the HTTP API. This results in a "You do not have permission to access this pad" message being shown to the shared notes user. To work around this issue, the pad's default text is set to a zero-width space character. For more information, see the relevant Etherpad issue.
In Etherpad 1.9.1, serializing the Pad object with
JSON.stringify()removes theidattribute of the pad since it implements its owntoJSONmethod (see ether/etherpad-lite#5814). As a workaround, apadIdattribute is manually added in such cases. The lack of apadIdbreaks BBB's captions and ability to bring back notes from breakout rooms.Hence, the following changes have to be in place before merging this PR:
ep_redis_publisher: Upgrade Redis plugin to support Etherpad 1.9.1 mconf/ep_redis_publisher#7bbb-pads: Changes for Etherpad 1.9.1 upgrade bbb-pads#26