New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(tests): Improve the handling of failures during the workflow #18390
Merged
gustavotrott
merged 16 commits into
bigbluebutton:v2.7.x-release
from
gustavotrott:test-to-fail-automated-test
Aug 1, 2023
Merged
ci(tests): Improve the handling of failures during the workflow #18390
gustavotrott
merged 16 commits into
bigbluebutton:v2.7.x-release
from
gustavotrott:test-to-fail-automated-test
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oon as a command fails
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
gustavotrott
changed the title
test: Check if CI will fail the workflow
tests: Improve the handling of failures during the workflow
Jul 28, 2023
antonbsa
approved these changes
Aug 1, 2023
gustavotrott
merged commit Aug 1, 2023
be057ac
into
bigbluebutton:v2.7.x-release
3 of 5 checks passed
antobinary
changed the title
tests: Improve the handling of failures during the workflow
ci(tests): Improve the handling of failures during the workflow
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the handling of failures during the automated-test workflow.
Currently, most of the commands run inside a block like this:
As it turns out, if command 2 fails and command 3 succeeds, the Step will still be marked as Successful. However, the correct behavior would be for it to fail!
So, I've tweaked most of the steps to run in a block like this:
In this way, if one of the commands fails, the Step will be marked as a Failure. This will help us identify where the problem lies.
Additionally, I've tweaked the
wget
command to use the-nv
(non-verbose) parameter instead of-q
. This is because-q
was suppressing the error message, making it more difficult to pinpoint the problem.