Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download of original presentation not working not working #18459

Merged
merged 1 commit into from Aug 10, 2023

Conversation

GuiLeme
Copy link
Collaborator

@GuiLeme GuiLeme commented Aug 7, 2023

What does this PR do?

This fixes the issue where it is not possible to download the original presentation.

Closes Issue(s)

Closes #18446

Motivation

As mentioned by @danielpetri1 in #18150, we changed the way we build the absolute URL for downloading the presentations due to clustering issues:

From now on, links will be created without the need for the bbbWebBase information, letting Meteor alone handle this on the client side

More

This PR was already tested on a cluster environment, but any further testing is welcome!!
@schrd, if you have any suggestions, please, comment them down!! Thank you in advance!

@GuiLeme GuiLeme marked this pull request as ready for review August 7, 2023 19:51
@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ramonlsouza ramonlsouza added this to the Release 2.7 milestone Aug 8, 2023
@gustavotrott gustavotrott self-requested a review August 8, 2023 16:49
Copy link
Collaborator

@gustavotrott gustavotrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well done!

@gustavotrott gustavotrott changed the title fix: download of original presentation fix: download of original presentation not working not working Aug 10, 2023
@gustavotrott gustavotrott merged commit 456950a into bigbluebutton:v2.7.x-release Aug 10, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants