Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audio): clear connection timeout on autoplay failures #18497

Conversation

prlanzarin
Copy link
Member

What does this PR do?

  • fix(audio): clear connection timeout on autoplay failures
    • If the autoplay block is triggered in listen only, the connection timer
      keeps ticking even if the user correctly accepts the audio play prompt.
      That causes an audio re-connect once the timeout expires.
    • Clear the connection timer if the audio bridge starts with
      NotAllowedError as a soft error. For connection purposes, the audio join
      procedure worked. The autoplay thing is at the UI/UX level, not WebRTC.

Closes Issue(s)

None

More

Follow up to #18407

If the autoplay block is triggered in listen only, the connection timer
keeps ticking even if the user correctly accepts the audio play prompt.
That causes an audio re-connect once the timeout expires.

Clear the connection timer if the audio bridge starts with
NotAllowedError as a soft error. For connection purposes, the audio join
procedure worked. The autoplay thing is at the UI/UX level, not WebRTC.
@prlanzarin prlanzarin added this to the Release 2.7 milestone Aug 9, 2023
@prlanzarin prlanzarin marked this pull request as ready for review August 9, 2023 14:13
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@prlanzarin prlanzarin merged commit db53478 into bigbluebutton:v2.7.x-release Aug 9, 2023
15 of 16 checks passed
@prlanzarin prlanzarin deleted the u27/fix/lo-autoplay-timeout branch August 9, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant