refactor: replace debounce function #18503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antobinary
reviewed
Aug 9, 2023
| @@ -0,0 +1,43 @@ | |||
| export function debounce(func, delay, options = {}) { | |||
There was a problem hiding this comment.
Could you add a few lines of explanation for the function (including that options is comprised of leading, trailing etc)? I.e. lodash, radash, missing options...
|
Kudos, SonarCloud Quality Gate passed!
|
antobinary
approved these changes
Aug 10, 2023
antobinary
merged commit 5a878c6
into
bigbluebutton:v2.7.x-release
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces radash debounce with a native function.
Motivation
The existing debounce implementation (from radash) lacks support for the
leadingandtrailingmodifiers. As a result, certain inconsistencies were found in its behavior (thanks @prlanzarin!) compared to the previously used library (lodash).