fix: Move Presentation Option Dropdown To The Left Side #18538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update menu ids
2.6 a11y fixes 01
26 a11y fixes 02
26 a11y fixes 03
…button into v2.6.x-release
…bluebutton into v2.6.x-release
ramonlsouza
requested changes
Aug 11, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
ramonlsouza
approved these changes
Aug 11, 2023
ramonlsouza
pushed a commit
to ramonlsouza/bigbluebutton
that referenced
this pull request
Aug 11, 2023
…n#18538) * prevent duplication of presentation menu dropdown when visible * move presentation options dropdown to the left (out of tldraw UI) * adjust style menu UI in RTL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR relocates the Presentation Option Dropdown to the left of the presentation to correct the semantic ordering of the elements. Previously, attempts to inject the component into the Tldraw UI resulted in element duplications. By moving the menu, we can maintain the correct semantic tab order without resorting to hacky solutions.
Closes Issue(s)
Closes #18505