-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor (graphql-server): Add presentation upload status data to Postgres #18567
refactor (graphql-server): Add presentation upload status data to Postgres #18567
Conversation
This pull request has conflicts ☹ |
58bf3d4
to
5e2f6ac
Compare
akka-bbb-apps/src/main/scala/org/bigbluebutton/core/db/PresPresentationDAO.scala
Outdated
Show resolved
Hide resolved
Looks like the msg Take a look at second 00:38: error-msg-cleared.mp4Moreover: The flag |
Maybe it is a good idea to create a flag In this case the prop |
...scala/org/bigbluebutton/core/apps/presentationpod/PresentationPageCountErrorPubMsgHdlr.scala
Outdated
Show resolved
Hide resolved
It is not storing presentations with error type graphql-doesnt-store-pres-mime-error.no-audio.mp4It's also missing some extra information to be able to render the error message, for instance: I suggest to create a generic TEXT column to store this extra info about the error, just like we have to store URLS: |
SonarCloud Quality Gate failed. 2 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Automated tests Summary🚨 Test workflow has failedClick here to check the action test reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What does this PR do?
During the presentation upload process data related to the total number of pages being uploaded and the current number of uploaded pages is sent from
bbb-web
toakka-apps
on to the client which is used to show the presentation upload status toast window. This information has been added to Postgres so that the client can access this information through GraphQL instead of being sent the information through an event.