fix (accessibility): Improve Keyboard Functionality With Tldraw Style Menu #18654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
ramonlsouza
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enhances the keyboard functionality within the tldraw style menu. Users can now navigate items using just the arrow keys, eliminating the need to hold down the tab key in combination with the arrow keys.
Motivation
The existing setup did not provide a straightforward way for users to access style options via the keyboard. Previously, after activating the style menu using the spacebar, users had to hold down the 'tab' key and use the 'up' or 'down' arrow keys to navigate the list. This change offers a more intuitive user experience.