Fix: TypeScript and Lint Errors in Recording indicator, Talking indicator, and Layout types (and additional lint rules). #18661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tainan404
requested changes
Aug 31, 2023
...uebutton-html5/imports/ui/components/nav-bar/nav-bar-graphql/talking-indicator/component.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| if (isBreakoutLoading) return null; | ||
| if (isBreakoutError) return (<div>error: {JSON.stringify(talkingIndicatorError)}</div>); | ||
| if (talkingIndicatorError || isBreakoutError) { |
There was a problem hiding this comment.
why do you accepts talkingIndicatorError here, but not reders or log it?
bigbluebutton-html5/imports/ui/components/nav-bar/nav-bar-graphql/talking-indicator/service.ts
Outdated
Show resolved
Hide resolved
Tainan404
approved these changes
Sep 5, 2023
Automated tests Summary🚨 Test workflow has failedClick here to check the action test reports |
|
This pull request has conflicts ☹ |
…-and-talking-indicator
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request addresses TypeScript (TS) and lint errors that were identified in the Recording indicator, Talking indicator, and Layout types. The changes made in this PR enhance the code quality, improve stability, and promote adherence to coding standards. Aditionally improves lint rule setting to make work and maintence on the code easier and more organized.