-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: migrate waitingUserPanel to TS and graphql #18677
Refactor: migrate waitingUserPanel to TS and graphql #18677
Conversation
Tested locally and could confirm the failed tests:
also: setting "Always accept" or "Always Deny" when there's a pending users, the panel goes into a buggy behavior: Peek.2023-09-01.12-08.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and everything is working as expected! There are some failing tests related to guest policy that will be fixed in an upcoming PR, re-enabling on CI as well
This pull request has conflicts ☹ |
This pull request has conflicts ☹ |
6fc2dcd
to
1d14cfa
Compare
Kudos, SonarCloud Quality Gate passed! |
f05cfd0
into
bigbluebutton:v3.0.x-release
What does this PR do?
This PRs migrates the guest user Panel to TS and graphql