Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: migrate waitingUserPanel to TS and graphql #18677

Conversation

Tainan404
Copy link
Member

What does this PR do?

This PRs migrates the guest user Panel to TS and graphql

@antonbsa
Copy link
Member

antonbsa commented Sep 1, 2023

Tested locally and could confirm the failed tests:

  • Guest policy › ASK_MODERATOR > Remember choice
  • Guest policy › ASK_MODERATOR > Allow Everyone
  • Guest policy › ASK_MODERATOR > Deny Everyone

also: setting "Always accept" or "Always Deny" when there's a pending users, the panel goes into a buggy behavior:

Peek.2023-09-01.12-08.mp4

Copy link
Member

@antonbsa antonbsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything is working as expected! There are some failing tests related to guest policy that will be fixed in an upcoming PR, re-enabling on CI as well

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@antobinary antobinary changed the base branch from develop to v3.0.x-release September 25, 2023 19:53
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gustavotrott gustavotrott merged commit f05cfd0 into bigbluebutton:v3.0.x-release Oct 6, 2023
19 of 28 checks passed
@danimo danimo mentioned this pull request Nov 28, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants