fix(recording): handle archive remux failures #18737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kepstin
requested changes
Sep 7, 2023
Recording archive may fail when remuxing invalid files from KMS or the new recorder - eg when the raw files are 0-byte sized. This commit handles the exception raised by EDL::encode so archive keeps going, logs the issue as a warning and archives the problematic file anyways. EDL::encode now removes the temporary file when the ffmpeg command execution fails - this should avoid leaving any stale files around in case of failure. No specific check for the nature of the error is done - the idea is that subsequent phases will discard or fix the files if necessary according to the processing scripts' necessities, making the behavior (in this specific scenario) similar to what it was before the archive remuxing was introduced.
prlanzarin
force-pushed
the
u27/fix/remux-skip-0b
branch
from
b4f5269
to
40b6429
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Automated tests Summary🚨 Test workflow has failedClick here to check the action test reports |
kepstin
approved these changes
Sep 7, 2023
antobinary
merged commit fad5385
into
bigbluebutton:v2.7.x-release
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
new recorder - eg when the raw files are 0-byte sized.
going, logs the issue as a warning and archives the problematic file anyways.
fails - this should avoid leaving any stale files around in case of failure
subsequent phases will discard or fix the files if necessary according
to the processing scripts' necessities, making the behavior (in this
specific scenario) similar to what it was before the archive remuxing was
introduced.
Closes Issue(s)
Closes #18720