Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove lodash #18742

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix: remove lodash #18742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...r-list/user-list-content/user-participants/user-list-participants/list-item/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ import { EMOJI_STATUSES } from '/imports/utils/statuses';
import TooltipContainer from '/imports/ui/components/common/tooltip/container';
import Auth from '/imports/ui/services/auth';
import { LockSettings } from '/imports/ui/Types/meeting';
import _ from 'lodash';
import { uniqueId } from '/imports/utils/string-utils';

const messages = defineMessages({
moderator: {
id: 'app.userList.moderator',
Expand Down Expand Up @@ -61,14 +62,14 @@ const UserListItem: React.FC<UserListItemProps> = ({ user, lockSettings }) => {
(user.mobile && LABEL.mobile) && intl.formatMessage(messages.mobile),
(user.locked && lockSettings.hasActiveLockSetting && !user.isModerator)
&& (
<span key={_.uniqueId('lock-')}>
<span key={uniqueId('lock-')}>
<Icon iconName="lock" />
&nbsp;
{intl.formatMessage(messages.locked)}
</span>
),
user.lastBreakoutRoom?.currentlyInRoom && (
<span key={_.uniqueId('breakout-')}>
<span key={uniqueId('breakout-')}>
<Icon iconName="rooms" />
&nbsp;
{user.lastBreakoutRoom?.shortName
Expand All @@ -77,7 +78,7 @@ const UserListItem: React.FC<UserListItemProps> = ({ user, lockSettings }) => {
</span>
),
(user.cameras.length > 0 && LABEL.sharingWebcam) && (
<span key={_.uniqueId('breakout-')}>
<span key={uniqueId('breakout-')}>
{ user.pinned === true
? <Icon iconName="pin-video_on" />
: <Icon iconName="video" /> }
Expand Down
6 changes: 0 additions & 6 deletions bigbluebutton-html5/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions bigbluebutton-html5/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
"html-to-image": "^1.9.0",
"immutability-helper": "~2.8.1",
"langmap": "0.0.16",
"lodash": "^4.17.21",
"makeup-screenreader-trap": "0.0.5",
"meteor-node-stubs": "^1.2.1",
"mobx": "6.4.2",
Expand Down Expand Up @@ -109,9 +108,8 @@
"yaml": "^2.2.2"
},
"devDependencies": {
"@types/lodash": "^4.14.197",
"@types/react-virtualized": "^9.21.22",
"@types/meteor": "^2.9.3",
"@types/react-virtualized": "^9.21.22",
"@types/styled-components": "^5.1.26",
"@types/uuid": "^9.0.2",
"@typescript-eslint/eslint-plugin": "^6.4.0",
Expand Down