Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (graphql): Userlist sorting uppercase wrongly (introduces user.nameSortable) #18779

Merged
merged 2 commits into from Sep 14, 2023
Merged

fix (graphql): Userlist sorting uppercase wrongly (introduces user.nameSortable) #18779

merged 2 commits into from Sep 14, 2023

Conversation

gustavotrott
Copy link
Collaborator

@gustavotrott gustavotrott commented Sep 14, 2023 •
edited

The userlist is being sorted wrongly because of Upper/Lowercase and Accents chars.
This PR fix this problem:

Before After

image

image

Moreover:

  • Collate C.UTF-8: On creating bbb_graphql database set LC_COLLATE 'C.UTF-8' - forcing the database to behave in same way independently of the server locale
  • nameSortable: Add a new indexed column nameSortable to user table, which is the name in lowercase and without accents, meant for sorting

@gustavotrott gustavotrott added this to the Release 2.8 milestone Sep 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

TiagoJacobs
TiagoJacobs requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@TiagoJacobs TiagoJacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make more clear that C.UTF-8 is to stabilize the behaviour and that actual fix comes in the new indexed, lowercase accents-free column.

TiagoJacobs
TiagoJacobs approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@TiagoJacobs TiagoJacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new PR description, it's ready for merge

@gustavotrott gustavotrott merged commit 61c4792 into bigbluebutton:develop Sep 14, 2023
18 of 28 checks passed
@gustavotrott gustavotrott deleted the fix-userlist-sorting branch October 11, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiagoJacobs TiagoJacobs TiagoJacobs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gustavotrott @TiagoJacobs