Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bbb-webhooks set secret and url #18789

Merged
merged 1 commit into from Sep 15, 2023

Conversation

antobinary
Copy link
Member

What does this PR do?

Sets the correct salt + url for bbb-webhooks

Closes Issue(s)

Closes #18740

Motivation

We were using bigbluebutton.properties rather than /etc/bigbluebutton/bbb-web.properties. I was trying to think of scenarios where bbb-conf does not exist at the time of bbb-webhooks installation, but can't think of one.

More

Credits: @snadal for suggesting this in #18740 (comment)

@antobinary antobinary added this to the Release 2.7 milestone Sep 15, 2023
@antobinary antobinary merged commit 3a58ce4 into bigbluebutton:v2.7.x-release Sep 15, 2023
14 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions
Copy link

Automated tests Summary

All the CI tests have passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant