Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client: Tooltip added to timer #18795

Merged
merged 2 commits into from Sep 21, 2023
Merged

Client: Tooltip added to timer #18795

merged 2 commits into from Sep 21, 2023

Conversation

Scroody
Copy link
Collaborator

@Scroody Scroody commented Sep 15, 2023 •
edited

What does this PR do?

This PR adds a Tooltip to BBB timer tool.

Closes Issue(s)

#18442

@antobinary antobinary added this to the Release 2.7 milestone Sep 15, 2023
@ramonlsouza ramonlsouza self-requested a review September 18, 2023 12:25
ramonlsouza
ramonlsouza requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@ramonlsouza ramonlsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tooltip is correctly displayed, but:

  • the tooltip always says "the timer", even when stopwatch is selected
  • time is only updated when the timer/stopwatch is activated/stopped... is this the expected behavior?
simplescreenrecorder-2023-09-18_09.48.40.mp4

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

Automated tests Summary

✅ All the CI tests have passed!

@ramonlsouza ramonlsouza merged commit f8b4fb0 into bigbluebutton:v2.7.x-release Sep 21, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonlsouza ramonlsouza ramonlsouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Scroody @ramonlsouza @antobinary