Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Add chat message to Postgres when user status changes #18980

Merged

Conversation

paultrudel
Copy link
Collaborator

What does this PR do?

Inserts a chat message from the system into Postgres when a user changes their away status.

Motivation

When a user's away status changes a message should be sent in chat to notify other users of this change.

@gustavotrott gustavotrott self-requested a review November 8, 2023 14:40
@antobinary antobinary added this to the Release 3.0 milestone Nov 8, 2023
Copy link
Collaborator

@gustavotrott gustavotrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure the message is written using internationalization . There are two messages app.chat.away and app.chat.notAway that were created for this purpose.

Copy link
Collaborator

@gustavotrott gustavotrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lockSettingsProps.disablePublicChat validation is wrong.

Copy link

sonarcloud bot commented Nov 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

Automated tests Summary

🚨 Test workflow has failed


Click here to check the action test reports

Copy link
Collaborator

@gustavotrott gustavotrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@gustavotrott gustavotrott merged commit f9f419c into bigbluebutton:v3.0.x-release Nov 14, 2023
27 of 28 checks passed
@danimo danimo mentioned this pull request Nov 28, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants