fix: specify a unique mock authToken for dial-in users, + #19084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every dial in user has its RegistedUser authToken set to an empty string, Since authToken is the RegUser's HashMap indexing key, this causes a bunch of inconsistencies; eg.: endpoint ejection will stop working if more than one dial-in user joined a meeting concurrently because the later dial-in devices overwrite the earlier ones in the RegUsers map. The authToken is now mocked as the user's intId (which, for dial-in, is the voice user ID) so that some sort of uniqueness is guaranteed within the voice conf scope.
userColor and avatar arguments of RegisteredUsers.create were incorrectly placed
|
Kudos, SonarCloud Quality Gate passed!
|
Automated tests Summary✅ All the CI tests have passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since authToken is the RegUser's HashMap indexing key, this causes a
bunch of inconsistencies; eg.: endpoint ejection will stop working if
more than one dial-in user joined a single meeting because the
later dial-in devices overwrite the earlier ones in the RegUsers map.
the voice user ID) so that some sort of uniqueness is guaranteed within
the voice conf scope.
Closes Issue(s)
None