feature (api): Add preUploadedPresentation param to API's /create via GET #19116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scroody
force-pushed
the
preUploadedPresentation-get-v30
branch
from
3555e16
to
6af3d4f
Compare
Fix hasPresentationUrlInParameter
|
Kudos, SonarCloud Quality Gate passed!
|
Automated tests Summary✅ All the CI tests have passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It basically implements the pre-upload presentation via GET, so now it is possible to pass a download URL to the create endpoint.
The behavior now is: if one passes in preUploadedPresentation, then this presentation will override the default.pdf, since preUploadedPresentationOverrideDefault=true by default in the application.properties. To avoid that, it is necessary to also send in preUploadedPresentationOverrideDefault=false.
As described by @GuiLeme the original author of the PR in the 2.7 version. PR - #18953