Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graphql API for clusterproxy setup #19207

Merged

Conversation

schrd
Copy link
Collaborator

@schrd schrd commented Nov 24, 2023

What does this PR do?

It fixes BBB 3.0 for a cluster proxy setup. Two things have to be fixed:

  • the client needs to make a connection directly to the BBB server
  • the bbb-graphql-middleware needs to accept requests with a different Origin header.

Updated setup instructions accordingly.

Motivation

I want client settings in local storage consistent across all my BBB server. I need a cluster setup.

@gustavotrott gustavotrott self-requested a review November 24, 2023 14:15
@gustavotrott gustavotrott added this to the Release 3.0 milestone Nov 24, 2023
The websocket connection to the graphql API needs to go directly to the
BBB server (bbb-html5) and it the middleware needs to accept requests
with a different origin.
Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

Automated tests Summary

All the CI tests have passed!

Copy link
Collaborator

@gustavotrott gustavotrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@gustavotrott gustavotrott merged commit 16c8715 into bigbluebutton:v3.0.x-release Nov 28, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants