Fix: away and raiseHands 'reactions' being hidden by avatar image #19266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
Automated tests Summary✅ All the CI tests have passed! |
Ithanil
changed the title
|
@antobinary Any chance to get this fix with 2.7.4? |
|
Hi Jan, great to see you last week in Berlin at the 18th BigBlueButton Developer Summit. While I can't speak on behalf of Anton, this looks like a good candidate for 2.7.4. |
|
@ffdixon That would be neat! Some people really enjoy the avatar feature, but also want to use the "away" status effectively. |
ramonlsouza
approved these changes
Jan 15, 2024
antobinary
merged commit 792add0
into
bigbluebutton:v2.7.x-release
24 of 25 checks passed
|
Thank you for this fix, @Ithanil ! |
|
Thank you for merging, some people will be happy about this being fixed. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #19263 by also filtering the avatar when user.away or user.raiseHands are true. Before it was only done for the reactions from the reactions bar.
Closes Issue(s)
Closes #19263