Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(whiteboard): prevent annotation subscription from being recreated #19502

Merged
merged 2 commits into from Jan 25, 2024

Conversation

JoVictorNunes
Copy link
Collaborator

What does this PR do?

Prevents annotation subscription from being recreated.
Removes annotation data duplication.

Closes Issue(s)

Closes #19495

Motivation

Since the GraphQL data stream sends all data on first render and then sends only updates, we don't need to use a query to grab initial annotation data.

Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Automated tests Summary

All the CI tests have passed!

@antobinary antobinary added this to the Release 3.0 milestone Jan 24, 2024
@ramonlsouza ramonlsouza merged commit 3049958 into bigbluebutton:v3.0.x-release Jan 25, 2024
25 checks passed
@Wladimir-N
Copy link

b34840d8-d0e6-4fe5-b651-10ea5654664a
Tell me, does this fix in 3.0 solve this problem? Only I have it on bbb 2.7.3

@ffdixon
Copy link
Member

ffdixon commented Mar 6, 2024

This fix is related to the work in 3.0 to move to GraphQL as the underlying communication between the BigBlueButton client/server.

Are you able to reproduce the issue on

https://demo.bigbluebutton.org/

which is running BigBlueButton 2.7.4?

@Wladimir-N
Copy link

This fix is related to the work in 3.0 to move to GraphQL as the underlying communication between the BigBlueButton client/server.

Are you able to reproduce the issue on

https://demo.bigbluebutton.org/

which is running BigBlueButton 2.7.4?

I can't even imagine how to reproduce this. This happens for one specific class, and not always. We tried to reproduce it on purpose, but it didn’t work. Or maybe one of the students found a bug and is sabotaging the lesson. Well, for obvious reasons, it doesn’t specifically reproduce this in test classes. The problem was on older versions and was reproduced more often. Now on 2.7.6 there are noticeably fewer complaints. However, if you stick to the version that one of the students reproduces this on purpose, then perhaps it’s not the version, but the fact that there was increased interest in this and he began to do it less often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants