Migrate auth and settings to graphQL (was meteor) #19507
Conversation
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
…s related to intl
| const { children, Fallback } = this.props; | ||
|
|
||
| return (error ? (<Fallback {...this.state} />) : children); | ||
| const fallbackElement = Fallback && error | ||
| ? <Fallback error={error || {}} errorInfo={errorInfo} /> : <div>Something went wrong</div>; |
There was a problem hiding this comment.
i18n needed for Something went wrong
There was a problem hiding this comment.
Yes, it is, but this is being used in the fallback of error boundary and the intl loader is bellow the boundary, so the provider it's not accessible before it
| callback(endedReason, () => Meteor.disconnect()); | ||
| logger[log]({ logCode: 'startup_client_usercouldnotlogin_error' }, `User could not log in HTML5, hit ${code}`); | ||
| console.error({ logCode: 'startup_client_usercouldnotlogin_error' }, `User could not log in HTML5, hit ${code}`); |
There was a problem hiding this comment.
logger could be POSTed to the server. console.error is client only. Any chance we can keep logger?
There was a problem hiding this comment.
The logger is heavely dependent of the settings that are loaded after this component be loaded
| if (errorMessageDescription in intlMessages) { | ||
| errorMessageDescription = intl.formatMessage(intlMessages[errorMessageDescription]); | ||
| if (error) { | ||
| errorMessageDescription = `Error: ${JSON.stringify(error)} |
There was a problem hiding this comment.
Looks like this log may actually include newline characters, making it difficult to parse/consume. Please double check or just use spaces instead of newline.
| permission: | ||
| columns: | ||
| - clientSettingsJson | ||
| - meetingId |
There was a problem hiding this comment.
why did you add this prop if it is not being used?
| @@ -15,10 +15,11 @@ select_permissions: | |||
| meetingId: | |||
| _eq: X-Hasura-MeetingId | |||
| comment: "" | |||
| - role: not_joined_bbb_client | |||
| - role: pre_join_bbb_client | |||
There was a problem hiding this comment.
This change should break the client!
| const client = new Client({ | ||
| host: 'localhost', | ||
| port: 5432, | ||
| database: 'bbb_graphql', | ||
| user: 'bbb_frontend', | ||
| password: 'bbb_frontend', | ||
| query_timeout: 30000, | ||
| }); |
There was a problem hiding this comment.
This values should come from an env config.
Just like Redis process.env.REDIS_HOST.
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
…s test" This reverts commit c7fc032.
… the isConnectionNotExpected init parameter
|
I've tried many times to reproduce the failure on |
|
This pull request has conflicts ☹ |
|
Automated tests Summary✅ All the CI tests have passed! |
|
Hello @Tainan404 - as we discussed, this PR opens door for removing some old code, like this one: I am merging it considering a subsequent cleanup PR is coming. |
What does this PR do?
This PR migrates the client settings to graphQL and also most parts of authtentication