Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(whiteboard): Ensure Only Presenter Has Ability to Pan Canvas #19583

Merged
merged 3 commits into from Mar 12, 2024

Conversation

KDSBrowne
Copy link
Collaborator

@KDSBrowne KDSBrowne commented Feb 5, 2024

What does this PR do?

This PR resolves an issue that allowed non-presenters to pan the canvas, a feature meant to be exclusive to the presenter until further controls for the infinite canvas are implemented. After this fix, only presenters will have the ability to pan the canvas, aligning with the intended functionality.

Closes Issue(s)

Partially closes #19580

@ramonlsouza ramonlsouza added this to the Release 3.0 milestone Feb 6, 2024
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@KDSBrowne
Copy link
Collaborator Author

Several attempts to override the mouse events from our side have been made; however, the encapsulation and handling of the custom pointer_down event within the tldraw library prevent external interception and modification.

To align with the intended functionality, where only presenters are permitted to pan the canvas, additional modifications directly to the tldraw library will be needed. This will involve altering the event handling logic that currently enables panning on middle mouse button actions.

The specific section of code that requires changes can be found here:
https://github.com/bigbluebutton/tldraw/blob/main/packages/editor/src/lib/editor/Editor.ts#L8729

Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Automated tests Summary

All the CI tests have passed!

@ramonlsouza ramonlsouza merged commit f76731f into bigbluebutton:v3.0.x-release Mar 12, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants