fix: Avoid presentation conversion causing a crash #19600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated tests Summary✅ All the CI tests have passed! |
antobinary
requested review from
ramonlsouza and
GuiLeme
and removed request for
ramonlsouza
antobinary
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checks if a presentation object is undefined before trying to set its
isCurrentvalue. Addresses a rare crash.Closes Issue(s)
Mitigates #19601 but does not fully close it.
Motivation
More
This patch avoids the crash but I am not quite sure of the exact reason why this object is undefined in some cases.
Also, it seems in some cases the list of presentations in the dialog is missing one of the presentations (with this patch). On re-opening of the dialog it seems fine. Let's see if others perhaps have better ideas about patching this.
In order to debug this and try the fix I resorted to spinning up a temporary 2.7.4 server with a dev environment. I used the ./deploy_to_usr_share.sh script in bbb-html5 to deploy changes as I could not hit the issue while in dev mode. I am happy to assist with the testing or further investigation work.