Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor (akka-apps): Switching from Meteor to GraphQL to determine whether user is connected #19611

Conversation

gustavotrott
Copy link
Collaborator

@gustavotrott gustavotrott commented Feb 9, 2024

This update focuses on enhancing the system's method of tracking user connection status, as part of the broader initiative to migrate away from Meteor. Traditionally, a user's connection status was determined by their interaction with Meteor. However, this change proposes leveraging GraphQL connections for this purpose.

The essence of this pull request is to shift the basis for marking a user as disconnected from their Meteor interactions to their activity with GraphQL connections. It introduces a system that actively observes a user's engagement with GraphQL. A user's connection will be registered upon connecting through GraphQL, and should they terminate all such connections, the system will mark the user as disconnected. This status change triggers the removal of the user from the room after a 30-second delay, maintaining consistency with the current functionality but without dependency on Meteor.

Note: The user.disconnected status is a rebranded version of what was previously known as leftFlag.

screen-recorder-fri-feb-09-2024-09-31-53.webm

@gustavotrott gustavotrott added this to the Release 3.0 milestone Feb 9, 2024
Copy link

sonarcloud bot commented Feb 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link

Automated tests Summary

All the CI tests have passed!

@gustavotrott gustavotrott merged commit f7cf603 into bigbluebutton:v3.0.x-release Feb 12, 2024
24 of 25 checks passed
@gustavotrott
Copy link
Collaborator Author

In order to work properly, it requires a subsequent PR removing the Meteor routines that monitor the user connections and perform some actions like Join/Leave, once now it will be monitored by Graphql connections.
cc @Tainan404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant