Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client: Poll answer verification #19621

Merged

Conversation

Scroody
Copy link
Collaborator

@Scroody Scroody commented Feb 13, 2024

What does this PR do?

This pull request introduces an answer verification feature for polls.

Motivation

The motivation behind this update stems from instances where polls remained unanswered, leading to unexpected behaviors like system messages lacking content for Typed polls or displaying empty graphic responses in True or False polls.

More

Now polling modal look after the changes:

No answers:
image

With answers:
image

@antobinary antobinary added this to the Release 3.0 milestone Feb 13, 2024
Copy link
Member

@ramonlsouza ramonlsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checking currentPoll.answers works for typed polls, but not for other types of polls (where currentPoll.answers has the poll options, like true and false)... In this case, currentPoll.responses could be checked instead

Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Automated tests Summary

All the CI tests have passed!

@ramonlsouza ramonlsouza merged commit 4f6d5f3 into bigbluebutton:v3.0.x-release Feb 26, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants