Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): priority for determining whether presentation is open #19631

Conversation

JoVictorNunes
Copy link
Collaborator

What does this PR do?

This PR determines a new priority for determining whether the presentation is open when the user enters a meeting as follows:

  1. Check if the user has provided userdata-bbb_hide_presentation_on_join (/join parameter). If so, start with this value. If not, start with hidePresentationOnJoin defined in settings.yml.
  2. If the presenter is pushing layout, overwrite the previous value with the meeting layout. Otherwise, keep the previous value.
  3. If there is screensharing or external video sharing, open the presentation anyways, overwriting the previous value.

So, the priority order for determining whether the presentation should be opened is as follows:

There is either screensharing or external video sharing > push layout > userdata-bbb_hide_presentation_on_join > hidePresentationOnJoin.

Closes Issue(s)

Closes #19456
Closes #17030

Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Automated tests Summary

All the CI tests have passed!

@antobinary antobinary added this to the Release 3.0 milestone Feb 15, 2024
@ramonlsouza ramonlsouza merged commit d15f541 into bigbluebutton:v3.0.x-release Feb 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants