fix(bbb-export-annotations): handle missing textbox size in Tldraw #19672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated tests Summary✅ All the CI tests have passed! |
antobinary
pushed a commit
to antobinary/bigbluebutton
that referenced
this pull request
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In certain situations, Tldraw fails to specify a size for the textbox shape, causing text rendering issues that crash the export process. This pull request introduces a check for this scenario, preventing the crash and adding appropriate exception handling to contain such errors to a single shape.
Closes Issue
Closes #19668
More
Thanks to @thuh-reflact for providing the fix.