fix(chat): audio and popup alerts #19675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonlsouza
requested changes
Feb 26, 2024
There was a problem hiding this comment.
if chat alerts are enabled when a poll is published, 2 alerts appear
new alerts will always replace the last one... is this expected?
simplescreenrecorder-2024-02-26_09.39.20.mp4
alerts appear again if presenter is changed:
simplescreenrecorder-2024-02-26_09.39.58.mp4
|
Yes, this is expected. But this may be a point of discussion to see what is the best behavior. IMHO always displaying the last message is the way, once displaying one toast for each message can flood the user's screen. Another way is using the pagination technique, but this can create large toasts as well. |
Automated tests Summary✅ All the CI tests have passed! |
ramonlsouza
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes both audio and popup alerts of chat.
Closes Issue(s)
Closes none