Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Increase answer size in poll results annotation #19711

Merged

Conversation

ramonlsouza
Copy link
Member

What does this PR do?

Increase maximum size for poll answer text in whiteboard annotation.

before

Presentation__2024-02-29T13_35_55 543Z

after

Presentation__2024-02-29T13_34_35 062Z

@ramonlsouza ramonlsouza added this to the Release 3.0 milestone Feb 29, 2024
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Automated tests Summary

All the CI tests have passed!

Copy link
Member

@antobinary antobinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@antobinary
Copy link
Member

Given that in this example one character represents 10% I would like to just try (as a group) whether 20% and 29% are shown equally wide if we had 20:29:51 distribution. A bit cumbersome to do locally. Also not sure I'd change anything even if it turned out to be the case. These graphs are somewhat rough, we have the percentage numbers written for a reason.

@antobinary antobinary changed the title Increase answer size in poll results annotation style: Increase answer size in poll results annotation Mar 1, 2024
@antobinary antobinary merged commit 342c8ec into bigbluebutton:v3.0.x-release Mar 1, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants