Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: timer sound issues #19715

Merged
merged 3 commits into from Mar 4, 2024
Merged

Fix: timer sound issues #19715

merged 3 commits into from Mar 4, 2024

Conversation

Scroody
Copy link
Collaborator

@Scroody Scroody commented Feb 29, 2024 •
edited

This PR aims to fix all the recent found issues involving the timer sounds in BBB. Such as:

  1. Timer - No song selected, both users could hear the song; - Found by the testing team.
  2. Timer - After finishing the first countdown, a mod selected a song and nobody could hear it. - Found by the testing team
  3. Timer - No sound bring played while timer sound enabled - Found by me in issue Timer music doesn't play in 3.0 version #19691.

@Scroody Scroody changed the title WIP WIP: Fix timer sound Feb 29, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@antobinary antobinary added this to the Release 3.0 milestone Mar 1, 2024
@Scroody Scroody changed the title WIP: Fix timer sound Fix: timer sound issues Mar 1, 2024
@Scroody Scroody marked this pull request as ready for review March 1, 2024 14:03
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Automated tests Summary

✅ All the CI tests have passed!

@ramonlsouza ramonlsouza merged commit a5f12cd into bigbluebutton:v3.0.x-release Mar 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonlsouza ramonlsouza ramonlsouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Scroody @ramonlsouza @antobinary