Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update playwright tests to support sha256 and sha512 algorithms #19725

Merged
merged 3 commits into from Mar 7, 2024

Conversation

paulseto
Copy link
Contributor

@paulseto paulseto commented Mar 3, 2024

What does this PR do?

Execute playwright tests with additional sha256 and sha512 algorithms.

Closes Issue(s)

No issue.

Motivation

Certain customers requires the use of only sha512 for checksums.

More

  • Added/updated documentation

Copy link

welcome bot commented Mar 3, 2024

Thank you for this contribution! Could you please confirm if you already sent in the signed Contributor License Agreement? See https://docs.bigbluebutton.org/support/faq.html#why-do-i-need-to-sign-a-contributor-license-agreement-to-contribute-source-code Thanks in advance!

@ffdixon
Copy link
Member

ffdixon commented Mar 3, 2024

We've got a contributor agreement in place.

@antobinary antobinary requested a review from antonbsa March 4, 2024 13:47
Copy link

github-actions bot commented Mar 4, 2024

Automated tests Summary

All the CI tests have passed!

@antobinary antobinary added this to the Release 2.7 milestone Mar 4, 2024
@antobinary antobinary changed the title update playwright tests to support sha256 and sha512 algorithms test: update playwright tests to support sha256 and sha512 algorithms Mar 6, 2024
Copy link
Member

@antonbsa antonbsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking pretty good! I ran it locally, and works as expected!

bigbluebutton-tests/playwright/.env.template Outdated Show resolved Hide resolved
Co-authored-by: Anton Barboza de Sá <antonbsa.bck@gmail.com>
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@antobinary antobinary merged commit fdbab50 into bigbluebutton:v2.7.x-release Mar 7, 2024
4 of 17 checks passed
antobinary added a commit to antobinary/bigbluebutton that referenced this pull request Mar 18, 2024
…bigbluebutton#19725)

* update to support sha256 and sha512 algorithms

* Update bigbluebutton-tests/playwright/.env.template

Co-authored-by: Anton Barboza de Sá <antonbsa.bck@gmail.com>

---------

Co-authored-by: Anton Georgiev <antobinary@users.noreply.github.com>
Co-authored-by: Anton Barboza de Sá <antonbsa.bck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants