fix(whiteboard): Selected Shapes Fail To Update On External Edits #19733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KDSBrowne
force-pushed
the
v30-update-while-selected
branch
2 times, most recently
from
4414a23
to
86bc7c1
Compare
|
This pull request has conflicts ☹ |
KDSBrowne
force-pushed
the
v30-update-while-selected
branch
from
86bc7c1
to
c70f116
Compare
|
Automated tests Summary✅ All the CI tests have passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR, following up on #19688, addresses a bug where shapes for viewers would not update correctly if selected while another user with appropriate privileges made updates to the same shape. This fix ensures that shape updates are reflected even while selected, improving the collaborative editing experience.
Motivation
before:
after:
