Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add global test hook #19747

Merged
merged 6 commits into from Mar 14, 2024

Conversation

antonbsa
Copy link
Member

@antonbsa antonbsa commented Mar 6, 2024

What does this PR do?

This PR adds a global hook to use the beforeEach by default performing the closing of the used context - without this action, Playwright keeps all the previous contexts open, which can result in a loss of performance throughout the tests. Since there's no built-in approach to apply this, I've used the fixture + extend + auto mode. We may benefit from this in different use cases, as our tests usually have many repeated actions.

More:

  • Fixes logout meeting function;
  • Fixes layout tests parameter;
  • Always keep the trace viewer of the test execution;
  • Removes the env variable DEBUG_MDOE;

@antonbsa antonbsa added this to the Release 3.0 milestone Mar 6, 2024
@antonbsa antonbsa requested a review from gabriellpr March 6, 2024 15:14
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

github-actions bot commented Mar 7, 2024

Automated tests Summary

All the CI tests have passed!

@ramonlsouza ramonlsouza merged commit c91108c into bigbluebutton:v3.0.x-release Mar 14, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants