refactor (graphql-middleware): Improve re-connection flow #19788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #19784
First improvement
When Hasura Client would re-connect, it was closing the channel
MsgReceivingActiveChan
to inform that the channelfromBrowserToHasuraChannel
should be frozen!Now the channel was renamed to
FreezeMsgFromBrowserChan
and it will just send a message to the channel instead of closing it:It was necessary because once the channel was closed, this
case
would start a loop (causing increase of CPU usage):Second improvement
Other loop was identified when the channel
fromHasuraToBrowserChannel
was closed.Now it will
break
the loop once it identifies the channel is closed (and the client will die soon).