Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor (graphql-middleware): Improve re-connection flow #19788

Conversation

gustavotrott
Copy link
Collaborator

@gustavotrott gustavotrott commented Mar 13, 2024

Following #19784

First improvement

When Hasura Client would re-connect, it was closing the channel MsgReceivingActiveChan to inform that the channel
fromBrowserToHasuraChannel should be frozen!
Now the channel was renamed to FreezeMsgFromBrowserChan and it will just send a message to the channel instead of closing it:
image

It was necessary because once the channel was closed, this case would start a loop (causing increase of CPU usage):
image


Second improvement

Other loop was identified when the channel fromHasuraToBrowserChannel was closed.
Now it will break the loop once it identifies the channel is closed (and the client will die soon).
image

@gustavotrott gustavotrott added this to the Release 3.0 milestone Mar 13, 2024
Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

Automated tests Summary

All the CI tests have passed!

@TiagoJacobs TiagoJacobs merged commit d1e2df7 into bigbluebutton:v3.0.x-release Mar 13, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants