Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong chat name displayed when poll is published #19808

Merged

Conversation

ramonlsouza
Copy link
Member

What does this PR do?

fix wrong chat id being set on poll publish

2024-03-15_09-33

@ramonlsouza ramonlsouza added this to the Release 3.0 milestone Mar 15, 2024
Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@antobinary
Copy link
Member

Does this mean that CHAT_CONFIG.public_id; == "Private Chat with"?

Copy link

Automated tests Summary

All the CI tests have passed!

@ramonlsouza
Copy link
Member Author

Does this mean that CHAT_CONFIG.public_id; == "Private Chat with"?

In this case, yes... Anything different than CHAT_CONFIG.public_group_id; is not considered "public chat" and will appear as "Private Chat with"

@antobinary antobinary merged commit 08b2054 into bigbluebutton:v3.0.x-release Mar 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants