Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor (graphql-middleware): Improve rate limiter and others #19839

Conversation

gustavotrott
Copy link
Collaborator

@gustavotrott gustavotrott commented Mar 18, 2024

  • Implements CustomRateLimiter once golang.org/x/time/rate was not cancelling disconnected clients properly
  • Add env var BBB_GRAPHQL_MIDDLEWARE_MAX_CONN_PER_SECOND=10
  • Remove env var BBB_GRAPHQL_MIDDLEWARE_RATE_LIMIT_IN_MS=50
  • HTML5 Client will wait 30 seconds (was 1 sec) for server response before creating a new Graphql WS Connection. It will be useful to save the client position in the queue when several users are connecting simultaneously
  • Improve websrv/connhandler.go once it was throwing panic errors in extreme situations

@gustavotrott gustavotrott added this to the Release 3.0 milestone Mar 18, 2024
Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
29 New issues
4 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.2% Duplication on New Code

See analysis details on SonarCloud

Copy link

Automated tests Summary

All the CI tests have passed!

@gustavotrott gustavotrott merged commit cc53d98 into bigbluebutton:v3.0.x-release Mar 18, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant