Refactor: Initial migration of bbb-web APIs #19918
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antobinary
reviewed
Mar 28, 2024
There was a problem hiding this comment.
I left some comments, did not try running yet.
Note [ to self ], this needs:
- packaging
- bbb-conf --setip/setsecret to set the salt in the config
- we should consider picking up overriding configs from
/etc/bigbluebutton/bbb-core-api-config.ymlor similar - Please try to include some README.MD in core-api and/or bbb-common-grpc explaining what we're looking at, how it's used, how to run as developer, some diagram you may have already.
Nice work so far!
...-bbb-apps/src/main/scala/org/bigbluebutton/core/apps/voice/UserLeftVoiceConfEvtMsgHdlr.scala
Show resolved
Hide resolved
akka-bbb-apps/src/main/scala/org/bigbluebutton/core/running/MeetingActor.scala
Show resolved
Hide resolved
...bbb-apps/src/main/scala/org/bigbluebutton/core2/message/handlers/GetMeetingInfoMsgHdlr.scala
Show resolved
Hide resolved
| // Create a source using the returned collection of RunningMeetings. | ||
| Source.future(runningMeetingsFuture).flatMapConcat { runningMeetings: VectorMap[String, RunningMeeting] => | ||
| // Consumers of this API can pass an optional meetingId argument indicating that the stream should begin from the corresponding RunningMeeting. | ||
| // Check if this argument has been provided. If not then use the entire collection of RunningMeetings. |
There was a problem hiding this comment.
+++++++ Really appreciate the level of inline comments here! 👏
|
This pull request has conflicts ☹ |
|
|
This pull request has conflicts ☹ |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes it so that meeting state from
akka-appsis used rather than the state frombbb-webto construct responses forisMeetingRunning,getMeetingInfo, andgetMeetingsAPI requests. A new application,bbb-core-api, has also been created that implements these endpoints and will implement otherbbb-webendpoints such ascreatein the future. Communication betweenbbb-core-apiandakka-appsis done through gRPC.The Protobuf definitions can be found in
bbb-common-grpc. Bothakka-appsandbbb-core-apiextract these definitions frombbb-common-grpcto generate the required Scala and Go code. Forakka-appsthis code is generated bysbtusing thecompiletask. Theproto-gen.shscript found inbbb-core-apiwill generate the required Go code. The Go code generation requiresprotobuf-compiler,protoc-gen-go, andproto-gen-go-grpcall installed and available on thePATH.Use the
run-dev.shscript inbbb-core-apito run the Go server.Motivation
Removal of application state from
bbb-webis part of the ongoing process to consolidate application state inakka-apps. Currently requests for information about meetings comes from the internal state ofbbb-webwhen it should instead be coming fromakka-appsThis is the first step in the process of totally removing application state from
bbb-weband migrating away from thebbb-webGrails API.